Skip to content

Route relay /new through thread actor - #3613

Merged
louis4li merged 2 commits into
feature/integratefrom
fix/2026-09-09_relay-new-conversation-thread
Sep 9, 2026
Merged

Route relay /new through thread actor#3613
louis4li merged 2 commits into
feature/integratefrom
fix/2026-09-09_relay-new-conversation-thread

Conversation

@louis4li

@louis4li louis4li commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Issue

Follow-up to #3611 and #3612.

Scope

  • Route NyxID relay ingress callbacks to the scoped ChannelConversationThreadGAgent instead of directly to ConversationGAgent.
  • Carry a typed conversation_actor_scope_key in NyxRelayInboundActivity so thread forwarding preserves tenant-scoped conversation actor ids.
  • Add relay-specific thread actor tests proving /new rotates to #session-00000001 and subsequent relay messages use the active logical conversation.

Verification

  • dotnet test test/Aevatar.GAgents.ChannelRuntime.Tests/Aevatar.GAgents.ChannelRuntime.Tests.csproj --nologo --filter "NyxIdRelayIngressPortTests|ChannelConversationThreadGAgentTests|ConversationDispatchMiddlewareTests|ChannelConversationTurnRunnerTests|ConversationGAgentRetainedHistoryClearTests" - 174 passed
  • bash tools/ci/test_stability_guards.sh - passed
  • bash tools/ci/architecture_guards.sh - passed
  • Production endpoint check - requires deployment of this follow-up fix

Notes

  • Existing /init/NyxID identity binding remains unchanged; /new only rotates the backend logical conversation mapping.
  • Expected post-deploy logs should show conversation=lark:dm:<user>#session-00000001 and target=channel-conversation:lark:dm:<user>#session-00000001:scope:<hash> after /new.

Generated with Claude Code.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@louis4li
louis4li requested a review from jason-aelf as a code owner September 9, 2026 15:31
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T15:35:07.370018Z 7e2a485 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7e2a485fea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread agents/Aevatar.GAgents.NyxidChat/NyxIdRelayIngressPort.cs
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@louis4li
louis4li merged commit f72488c into feature/integrate Sep 9, 2026
14 of 15 checks passed
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.47%. Comparing base (6cca55a) to head (fc93c44).
⚠️ Report is 4 commits behind head on feature/integrate.

@@                  Coverage Diff                  @@
##           feature/integrate    #3613      +/-   ##
=====================================================
- Coverage              83.47%   83.47%   -0.01%     
=====================================================
  Files                   1709     1709              
  Lines                 197842   197842              
  Branches               23740    23740              
=====================================================
- Hits                  165145   165142       -3     
- Misses                 21661    21667       +6     
+ Partials               11036    11033       -3     
Flag Coverage Δ
ci 83.47% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant