Repository navigation
Resolve @ParentCommand fields by type - #692
Merged
stalep merged 1 commit intoOct 25, 2026
Merged
Conversation
Member
|
Hi @dajiaohuang, thanks a lot for the pr! Looks good 👍 |
stalep
added a commit
that referenced
this pull request
Oct 26, 2026
Unit test drives the 5-arg populator with a hand-built two-frame context and asserts exact-instance resolution for two same-type fields plus an ancestor-typed field. Console end-to-end test enters nested sub-command mode and asserts the leaf observes values through both field types. Both verified to fail without the #692 fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #685: the normal-mode fix currently injects only the immediate parent into the first annotated field. That leaves additional @ParentCommand fields unset and can assign the wrong object when a field targets a higher ancestor.
Resolve every annotated field against the nearest ancestor matching its declared type in both generated and reflection paths. The parser passes the ancestor chain; sub-command-mode injection uses the same type-directed resolver. Keep the existing BiConsumer-compatible direct-parent entry point.
Regression coverage adds multiple parent fields, including a distinct ancestor type, for reflection and generated metadata paths.
Validation:
./mvnw.cmd -pl aesh -Dtest=GroupParentInjectionTest,ReadlineConsoleContextTest -Dsurefire.failIfNoSpecifiedTests=false test— 7 tests passed../mvnw.cmd -pl aesh-processor -am -Dtest=ProcessorTest -Dsurefire.failIfNoSpecifiedTests=false test— 92 tests passed.git diff --checkpassed.