Repository navigation
Respect explicitly configured AeshContext in ReadlineConsole runtime - #689
Merged
stalep merged 1 commit intoOct 22, 2026
Merged
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug where
ReadlineConsolealways ran commands under a runtime whose context was a fresh internal default, silently shadowing whatever was configured viaSettingsBuilder.aehsContext(...).Changes
ReadlineConsole— when an explicit context is configured on settings, use exactly that instance; otherwise keep today's managed fallback (new DefaultAeshContext(exportManager)) unchanged.Settings— additivedefault boolean hasExplicitAeshContext() { return true; }. External implementors are unaffected (their getter value was already used unconditionally byAeshCommandRuntimeBuilder.settings()); the console now honours it consistently too.SettingsImpl— precise explicitness tracking: setter marks on non-null, lazy default never does; copy constructor only carries explicitly configured contexts so copied settings keep their own fresh defaults.Why this shape
aeshContext()is always non-null (lazy init, relied upon widely), so "user set one" vs "lazy default" needed a distinguisher — hence the additive interface method rather than changing getter semantics or nullability.New regression test asserts
console.context()returns identically the instance passed via settings when explicitly configured, and that unset settings still fall back to a managed default. Full module suite green (1577 tests).Closes #687