Skip to content

Fix CDR types: remove empty relationship lists - #1064

Merged
armanddidierjean merged 1 commit into
mainfrom
fix-cdr-types
Sep 1, 2026
Merged

Fix CDR types: remove empty relationship lists#1064
armanddidierjean merged 1 commit into
mainfrom
fix-cdr-types

Conversation

@armanddidierjean

@armanddidierjean armanddidierjean commented Aug 31, 2026

Copy link
Copy Markdown
Member

Description

Summary

Currently Siarnaq does not show variants because of this bug

...

Issues/PR dependencies

Issues to be resolved

Required PRs

Changes Made

  • ...
  • ...

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.37%. Comparing base (731dd74) to head (9bb8994).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1064       +/-   ##
===========================================
- Coverage   84.97%   51.37%   -33.61%     
===========================================
  Files         220      220               
  Lines       16295    16295               
===========================================
- Hits        13847     8371     -5476     
- Misses       2448     7924     +5476     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@armanddidierjean
armanddidierjean merged commit 9e0aefe into main Sep 1, 2026
7 checks passed
@armanddidierjean
armanddidierjean deleted the fix-cdr-types branch September 1, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants