feat: add number helpers - #5145
Closed
deformator852 wants to merge 2 commits into
Closed
Conversation
Member
|
Hey! 👋🏻 Thanks for the contribution. I think these generic number helpers would fit better in I would also remove |
Author
|
Hi! Thank you! I'll take that into account |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Adds a
numberhelpers module, available as@adonisjs/core/helpers/number.Methods:
clamp(value, min, max)— constrain a number to the given boundsbetween(value, min, max)— check whether a number is inside an inclusive range (bounds may be passed in either order)toFinite(value, fallback?)— convert a value to a finite number, or return the fallback (default0)parse(value)— convert a value to a finite number, or returnnullformat(value, options?)— format a number viaIntl.NumberFormat(digits,compact)The same helpers are registered as the Edge global
number.Unit and Edge tests cover all methods, including
format.📝 Checklist