fix: regenerate indexes before restarting watch processes - #107
Open
RomainLanz wants to merge 1 commit into
Open
fix: regenerate indexes before restarting watch processes#107RomainLanz wants to merge 1 commit into
RomainLanz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! 👋
When a file is added or removed in watch mode,
DevServerandTestRunnerstart regenerating the generated indexes and immediately restart the server or re-run the tests.Since
IndexGenerator.addFileandIndexGenerator.removeFileare asynchronous, the new process may read a stale index. After a removal, that stale index may still import the deleted file.This PR waits for index regeneration before restarting the server or re-running the tests. The existing public hook order and HMR behavior remain unchanged.
The tests use a controlled promise to verify the ordering without relying on arbitrary timeouts.
Was there a reason for intentionally not awaiting these
IndexGeneratorcalls? Happy to adjust the change if the fire-and-forget behavior was required.Tests
DevServerandTestRunnerwatcher testsnpm run typechecknpm run lint