perf: speed up index generation sorting - #106
Open
RomainLanz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! 👋
VirtualFileSystem.scancurrently usesnaturalSort, which callslocaleComparewith collation options for every comparison. Sorting becomes the main CPU cost when generating indexes with hundreds or thousands of files.This PR creates one
Intl.Collatorwith the same options and reuses its bound comparator. It preserves the existing natural, case-insensitive, and accent-insensitive order. A focused test covers numbers, leading zeros, casing, accents, and nested directories.Benchmark
Node.js 24.20.0 using the public
IndexGeneratorAPI, with 12 independent before/after process pairs and alternating execution order.At 1,000 files, the CPU profile dropped from 2,120 ms to 673 ms across 60 generations.
The old and new comparators produced identical results across 4,206,601 comparisons and 100 shuffled stable sorts. A generated 1,000-file index was also byte-identical.
Validation