Repository navigation
chore: move type guards #10832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
chore: move type guards #10832
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,2 @@ | ||
| export { | ||
| addEvent, | ||
| getOwnerDocument, | ||
| getOwnerWindow, | ||
| isDocument, | ||
| isShadowRoot | ||
| } from '../../../src/utils/domHelpers'; | ||
| export {addEvent, getOwnerDocument, getOwnerWindow} from '../../../src/utils/domHelpers'; | ||
| export {isDocument, isShadowRoot} from '../../../src/utils/typeHelpers'; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export {isWindow, isDocument, isShadowRoot} from '../../../src/utils/typeHelpers'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Copyright 2026 Adobe. All rights reserved. | ||
| * This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. You may obtain a copy | ||
| * of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under | ||
| * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
| * OF ANY KIND, either express or implied. See the License for the specific language | ||
| * governing permissions and limitations under the License. | ||
| */ | ||
|
|
||
| /** | ||
| * Type guard that checks if a value is a Node. Verifies the presence and type of the nodeType | ||
| * property. | ||
| */ | ||
| export function isNode(value: unknown): value is Node { | ||
| return ( | ||
| value !== null && | ||
| typeof value === 'object' && | ||
| 'nodeType' in value && | ||
| typeof value.nodeType === 'number' | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Type guard that checks if a value is a Window. Uses window self reference checks to | ||
| * distinguish Window from other values. | ||
| */ | ||
| export function isWindow(value: unknown): value is Window & typeof globalThis { | ||
| return typeof value === 'object' && value != null && 'window' in value && value.window === value; | ||
| } | ||
|
|
||
| /** | ||
| * Type guard that checks if a value is a Document. Uses nodeType and host property checks to | ||
| * distinguish Document from other values. | ||
| */ | ||
| export function isDocument(value: unknown): value is Document { | ||
| return isNode(value) && value.nodeType === 9; | ||
| } | ||
|
|
||
| /** | ||
| * Type guard that checks if a value is a ShadowRoot. Uses nodeType and host property checks to | ||
| * distinguish ShadowRoot from other values. | ||
| */ | ||
| export function isShadowRoot(value: unknown): value is ShadowRoot { | ||
| // 11 = DOCUMENT_FRAGMENT_NODE | ||
| return isNode(value) && value.nodeType === 11 && 'host' in value; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly necessary, but I think it's a nice bit of reorganisation. Technically theses are on private paths, so we could just omit them from re-export here, but this seems like a nice thing to do