Skip to content

fix: #7500 Table Select All Column Header ID - #10370

Open
jsmitrah wants to merge 3 commits into
adobe:mainfrom
jsmitrah:fix/7500/table-select-all-columnHeader-id
Open

fix: #7500 Table Select All Column Header ID#10370
jsmitrah wants to merge 3 commits into
adobe:mainfrom
jsmitrah:fix/7500/table-select-all-columnHeader-id

Conversation

@jsmitrah

Copy link
Copy Markdown

Closes #7500

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  • Go to TableView in Storybook and open a story with multiple selection enabled.
  • Inspect the "Select All" checkbox column header using browser DevTools.
  • Verify that the id attribute uses the provided rowHeaderCustomColumnId prop and remains stable after page refreshes.

🧢 Your Project:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table: Allow specifying an id for 'select all' checkbox

1 participant