creating a new function that checks for uuid/olderUuid, if they are null they are populated and set in PreferencesManager#14374
Conversation
…ull they are populated and set in PreferencesManager
|
@niteskum Can you take a look at these changes ? |
| userGuids.userUuid = userUuid; | ||
| userGuids.olderUuid = olderUuid; | ||
|
|
||
| return result.resolve(userGuids); |
There was a problem hiding this comment.
I think you should be returning result.resolve(userGuids).promise().
|
|
||
| PreferencesManager.setViewState("UUID", userGuids.uuid); | ||
| PreferencesManager.setViewState("OlderUUID", userGuids.olderuuid); | ||
| return result.resolve(userGuids); |
There was a problem hiding this comment.
I think you should be returning result.resolve(userGuids).promise().
| if (userUuid && olderUuid) { | ||
| oneTimeHealthData.uuid = userUuid; | ||
| oneTimeHealthData.olderuuid = olderUuid; | ||
| return result.resolve(oneTimeHealthData); |
There was a problem hiding this comment.
you can remove the return here and just have result.resolve()
|
|
||
| userGuids.uuid = userUuid; | ||
| userGuids.olderuuid = olderUuid; | ||
| return result.resolve(userGuids); |
There was a problem hiding this comment.
you can remove the return here and just have result.resolve()
| } | ||
| }; | ||
|
|
||
| return result.resolve(ingestData); |
There was a problem hiding this comment.
you can remove the return here and just have result.resolve()
There was a problem hiding this comment.
I dont see a need for a return here.
| } | ||
| } | ||
| }); | ||
| return result.resolve(); |
There was a problem hiding this comment.
what is this dialog for ? Should the result be resolved once the dialog is shown ?
There was a problem hiding this comment.
dialog is to display the healthData json and adobe analytics json.
result should be resolved when dialog is displayed.
There was a problem hiding this comment.
then should we not move it inside the function ?
There was a problem hiding this comment.
or maybe we can add an always() and resolve it there.
|
@SnchitGrover there are quite a lot of redundant commits. can you squash some of them appropriately? |
|
|
||
| // So we are going to get the Machine hash in either of the cases. | ||
| if (appshell.app.getMachineHash) { | ||
| appshell.app.getMachineHash(function (err, macHash) { |
There was a problem hiding this comment.
@abose This functionality was already baked into brackets. I just moved it to a function so that can be called from multiple places.
There was a problem hiding this comment.
ah! got it. It just occurred to me that this is machine fingerprinting then. That is not a recommended practice for anonymous logging services. But the legality of that in desktop software might be different to that of hosted services. I think we should consider just using the randomly generated UUID[generated on the first launch as is the current behavior] here instead of hardwareID hashes that can uniquely identify a machine.
4 participants
@vickramdhawal