This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Autoupdate : Adding unit-test module#14306
Open
mbhavi wants to merge 4 commits intoadobe:masterfrom
Open
Conversation
Contributor
|
Can you please link the bugs which you have fixed as part of this PR? |
Contributor
Author
|
@navch , i have added the reference to the bugs above. |
shubhsnov
reviewed
May 9, 2018
| needButtons: true | ||
| }); | ||
| setAutoUpdateSessionInProgress(false); | ||
| showUpdateBar( Strings.DOWNLOAD_COMPLETE, Strings.CLICK_RESTART_TO_UPDATE, null, true); |
Collaborator
There was a problem hiding this comment.
It's best to keep optional parameters at the last, so that we can avoid passing arguments like null or empty objects. See if this can be fixed
Contributor
Author
|
I have split the PR into 2 independent PR's : one for bug fixes, and one for unit tests. |
mbhavi
changed the title
shubhsnov
reviewed
May 21, 2018
| _nodePath = "node/AutoUpdateDomain", | ||
| _domainPath = [_modulePath, _nodePath].join("/"), | ||
| updateDomain; | ||
| updateDomain, |
Collaborator
There was a problem hiding this comment.
These changes should not be part of this PR, as they are already present in 14320
| * @param {boolean} test - boolean to denote whether the API is invoked for unit testing | ||
| */ | ||
| function _updateProcessHandler(updates) { | ||
| function _updateProcessHandler(updates, test) { |
Collaborator
There was a problem hiding this comment.
Instead of passing a test parameter, we can have explicit test APIs which mock the normal behavior, á la ExtensionLoader.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autoupdate : Adding unit-test module
ping @swmitra, @shubhsnov , @navch for review