This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Remove unused acorn node module#14196
Open
boopeshmahendran wants to merge 1 commit intomasterfrom
Open
Conversation
Collaborator
|
LGTM 👍 |
Collaborator
|
I think you should be able to move those deps to the top level package.json and then remove this one. |
Contributor
|
@ficristo That's already there in brackets\src\package.json. @boopeshmahendran This looks safe to me. But JSUtil(session.js, HintUtils.js) uses different acron version(3.3). It will be great if you can have a look into that and fix that as well? Then JSUtils will completely clean. |
Collaborator
|
I think you should remove this file anyway and move
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.