Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Remove unused acorn node module#14196

Open
boopeshmahendran wants to merge 1 commit intomasterfrom
boopeshmahendran-patch-2
Open

Remove unused acorn node module#14196
boopeshmahendran wants to merge 1 commit intomasterfrom
boopeshmahendran-patch-2

Conversation

@boopeshmahendran
Copy link
Copy Markdown
Contributor

No description provided.

@shubhsnov
Copy link
Copy Markdown
Collaborator

LGTM 👍

@ficristo
Copy link
Copy Markdown
Collaborator

ficristo commented Apr 4, 2018

I think you should be able to move those deps to the top level package.json and then remove this one.

@navch
Copy link
Copy Markdown
Contributor

navch commented Apr 6, 2018

@ficristo That's already there in brackets\src\package.json.

@boopeshmahendran This looks safe to me. But JSUtil(session.js, HintUtils.js) uses different acron version(3.3). It will be great if you can have a look into that and fix that as well? Then JSUtils will completely clean.

@ficristo
Copy link
Copy Markdown
Collaborator

ficristo commented Apr 6, 2018

I think you should remove this file anyway and move tern dependecy to the top level package.json.
package.json files should be present:

  • at the top level (for node deps)
  • inside src folder (for browser deps)
  • inside extensions folder
  • for tests
    all the others should be removed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants