This repository was archived by the owner on Sep 6, 2021. It is now read-only.
fixed issue #11800#13934
Open
julietafrade97 wants to merge 1 commit intoadobe:masterfrom
julietafrade97:master
Open
fixed issue #11800#13934julietafrade97 wants to merge 1 commit intoadobe:masterfrom julietafrade97:master
julietafrade97 wants to merge 1 commit intoadobe:masterfrom
julietafrade97:master
Conversation
Author
|
I don't understand why this wasn't aprooved. Can someone explain? |
Collaborator
|
Hi @julietafrade97, sorry about that, I just haven't had the time to properly review / test it yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that when you try to increase or decrease the font size, brackets doesn't let you if the new font size is more than the maxium font size (72px) or less than the minium font size (1px). Therefore, if the the font size in themes settings is 100px and you try to drecrease it pressing Ctrl+- nothing happens because the new font size will be 99px which is still more than 72px.
Because I think it makes sense to be able to decrease the font size even though it is still more than the allowed I tried to solve the problem. So now if the font size is more than the maxium and you try to decrease it, it will decrese to the maxium font size, and if the font size is less than the minium and you increase it, it will increase to the minium font size.
I'm going to make a pull request now and wait for the update in the master repository.