Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Fixed Issue #13800 - Side-bar now readable on bigger screens#13933

Open
JoseFreixo wants to merge 9 commits intoadobe:masterfrom
JoseFreixo:Brackets-13800
Open

Fixed Issue #13800 - Side-bar now readable on bigger screens#13933
JoseFreixo wants to merge 9 commits intoadobe:masterfrom
JoseFreixo:Brackets-13800

Conversation

@JoseFreixo
Copy link
Copy Markdown

@JoseFreixo JoseFreixo commented Nov 27, 2017

Fixes Issue #13800

capturar

@JoseFreixo
Copy link
Copy Markdown
Author

Can someone give us an inclination as to what we might be doing wrong and is causing the pull request to be rejected?

@ficristo
Copy link
Copy Markdown
Collaborator

ficristo commented Dec 4, 2017

The error "API rate limit exceeded for..." can happen from time to time. When the github API are used too many times they could start failing with that message.
It has nothing to do with your PR.

@ficristo
Copy link
Copy Markdown
Collaborator

ficristo commented Dec 4, 2017

I'm sorry I cannot review your PR, but I have a question: if you resize the window the font size will change?

@JoseFreixo
Copy link
Copy Markdown
Author

@ficristo Yes, it is related to the height of the window. This is what makes the font bigger on bigger screens. But we believe that most people will keep the window height the same size as the screen and only change the width.

@swmitra
Copy link
Copy Markdown
Collaborator

swmitra commented Apr 23, 2018

@JoseFreixo Good work 👍
I have one suggestion -

Can we expose a preference for the UI Font size? In it's current form, Brackets provide customisation of Code view font size but not rest of the UI! If we can bridge that gap, then this feature would be definitely useful. Also, instead of just targeting Sidebar, if we can provide a solution to just change the base font size and removing all text size related hardcoding, that would make the whole editor more useful in various circumstances.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants