CEXT-6402: move banner-notification/custom-mass-actions into v1/#56
Closed
obarcelonap wants to merge 2 commits into
Closed
Conversation
Member
Author
|
Superseded by the approach of folding banner notification config into companion mass-action/view-button samples (CEXT-6410, CEXT-6413, CEXT-6411). Sample deletions will happen in the context of each companion ticket. README update applied to PR #53 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the V1
banner-notification/custom-mass-actionssample intoadmin-ui-sdk/v1/as part of the Admin UI SDK V1/V2 migration (CEXT-6400).Banner notifications have no standalone V2 equivalent — in V2 they are declared inline on each mass action as
notifications.success/notifications.error. This is documented in theadmin-ui-sdk/README.mdcomparison table.Related Issue
CEXT-6402 / CEXT-6400
Motivation and Context
Organising V1-only samples under
admin-ui-sdk/v1/to clearly separate them from future V2 samples.How Has This Been Tested?
Sample deployed to App Builder stage (project CEXT6400, workspace CEXT6402). Registration endpoint returns the expected payload with
bannerNotification.massActions.orderand.productentries.App URL: https://development-271530-cext6400-cext6402.dev.runtime.adobe.io/index.html
Screenshots (if appropriate):
N/A
Types of changes
Checklist: