-
Notifications
You must be signed in to change notification settings - Fork 0
Move Linux CI jobs to self-hosted runner #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ permissions: | |
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| runs-on: [self-hosted, Linux, X64] | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
|
|
@@ -43,7 +43,7 @@ jobs: | |
| run: ./dist/index.js --help | ||
|
|
||
| release: | ||
| runs-on: ubuntu-latest | ||
| runs-on: [self-hosted, Linux, X64] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The release job has Useful? React with 👍 / 👎. |
||
| needs: test | ||
| permissions: | ||
| contents: write | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ permissions: | |
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| runs-on: [self-hosted, Linux, X64] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
For pull requests, this job checks out contributor-controlled code and executes its build and tests on the self-hosted machine. If this repository accepts outside PRs and the runner is persistent or reused, an approved malicious PR can compromise the runner, retain credentials or persistence, and later intercept the write and OIDC tokens used by the release workflow sharing these labels. Use a GitHub-hosted runner for Useful? React with 👍 / 👎. |
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 | ||
|
|
@@ -43,7 +43,7 @@ jobs: | |
| ./dist/index.js edit-sequential --help | ||
|
|
||
| validate-implementation: | ||
| runs-on: ubuntu-latest | ||
| runs-on: [self-hosted, Linux, X64] | ||
| needs: test | ||
|
|
||
| steps: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release publish breaks on self-hosted
High Severity
The
releasejob now runs on a self-hosted runner while still requiring npm OIDC trusted publishing and provenance (id-token: write,NPM_CONFIG_PROVENANCE,npm publish --provenance, andpublishConfig.provenance). npm only accepts those from GitHub-hosted runners, so publishes fail with an E422 unsupportedrunner_environmenterror and releases stop shipping.Reviewed by Cursor Bugbot for commit a325701. Configure here.