lower tx_power to 15 for boards with chip antennas#11132
Draft
dhalbert wants to merge 2 commits into
Draft
Conversation
Collaborator
|
More to consider.
|
Boards identified by mikeysklar. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through all the boards in circuitpython.org that looked like they might have chip antennas based on their pictures (or lack of evidence contrary in their pictures, and tracked down whether they really did. Those boards had their default
tx_powerset to 15 dBm instead of the default 20. A few were already set, and one was already set to 11 dBm, which I left alone.I can't see the pass I did was perfect, but I think I got all or nearly all.
Interesetingly, may of the M5Stack boards use a slot metal antenna which is compact but not a chip antenna. I left those alone.
I have asked @UnexpectedMaker if this value makes sense for his boards, all of which seem to use chip antennas. This PR is draft until then.