Repository navigation
Test Rails 8.1 on PostgreSQL and MySQL; checkout@v4 everywhere - #1719
Merged
Merged
Conversation
The postgres and mysql jobs ran 8.0 and 7.2 only, so the newest Rails was covered on SQLite and Trilogy but not on the two databases where the SQL actually differs. Both matrices now start at 8-1-stable. actions/checkout@v2 (test, rubocop) and @V3 (codeql) are deprecated and warn on every run; the other workflows already use v4. No database versions change: postgres is the untagged image, MySQL is the runner's 8.0, SQLite is the gem's bundled library. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was opened by Claude (Claude Code), acting on behalf of @scarroll32.
Follow-up to the question of whether CI carries old database versions. It does not:
postgresis the untagged image (18 today), MySQL is the runner's 8.0, and SQLite is whatever thesqlite3gem bundles. What the matrix did have was a gap and a deprecation.postgresandmysqljobs ran8-0-stableand7-2-stableonly, so the newest Rails was covered on SQLite and Trilogy but not on the two databases whose SQL actually differs. Both matrices now start at8-1-stable. Two new jobs:postgres (8-1-stable, 3.2.2)andmysql (8-1-stable, 3.2.2).actions/checkout@v4intest.yml,rubocop.yml(were v2) andcodeql.yml(was v3). The other workflows already use v4.After merging
Branch protection on
mainlists the required job names explicitly. Once this is merged, the two new contexts should be added to the required list. That is deliberately not done in this PR: a required context that no open PR produces would block #1717 and #1718 until they were rebased.🤖 Generated with Claude Code