Repository navigation
Delete the screenshots the README no longer uses - #22
Merged
Merged
Conversation
The four images under screen/ were taken against an Active Admin whose form layout the gem no longer produces -- a Country form, a narrower label column, dates from 2015. The README now embeds a current screenshot hosted on GitHub, so nothing references them. They were never shipped: the whitelist in the gemspec has kept them out of the packaged gem since #8, and the file count there is unchanged at 6. This only removes 96 KB from the repository. The gemspec comment that cited screen/ as the cautionary example is reworded -- the reasoning for a whitelist stands, but the directory it pointed at is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four images under
screen/were taken against an Active Admin whose form layout this gem no longer produces — a Country form, a narrower label column, dates from 2015. The README now embeds a current screenshot hosted on GitHub, so nothing in the repository references them.Checked before deleting:
grepforscreen/across Markdown and JSON — no remaining referencesGem::Specification#files— 6 files before and after, unchanged. They were never in the published gem: the whitelist added in Publish only a whitelist of files in the gem #8 has excluded them all alongSo this removes 96 KB from the repository and nothing else.
Also rewords the gemspec comment that cited
screen/as the cautionary example for why the file list is a whitelist. The reasoning stands — a reject list needs a new pattern every time the repo grows a directory — but the directory it pointed at no longer exists.