Repository navigation
Scope the .ready() comment to the jQuery this gem runs on - #16
Merged
Merged
Conversation
The comment that shipped with the binding fix said jQuery 4 keeps the same .ready() implementation. That is true, but it is also beside the point: the gemspec pins activeadmin ~> 3.2, and Active Admin 3 requires jquery3 outright in its base.js, so this code only ever runs on jQuery 3. Reasoning about a version the gem cannot be installed alongside is noise in a file that ships to every consumer. State the jQuery 3 behaviour, which is the whole justification, and drop the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only follow-up to #14.
The comment that landed with the binding fix reads:
Accurate —
jQuery.fn.readyis present in 4.0.0 with the same Deferred-based body — but beside the point, and it ships to every consumer of the gem and the npm package.After #15 the gemspec declares
activeadmin ~> 3.2, and Active Admin 3'sbase.jsrequiresjquery3outright, so this code only ever runs on jQuery 3.7.1. A reader weighing a jQuery-4 caveat is weighing a configuration the gem refuses to install into.Keeps the justification that actually holds — jQuery 3 schedules
.ready()throughsetTimeout, so the popup was inert for a macrotask — and drops the rest.No behaviour change; the suite is unaffected.