Skip to content

Allow checking DNS with api.gihub.com.#4547

Merged
TingluoHuang merged 2 commits into
mainfrom
users/tihuang/dnscheck
Jul 15, 2026
Merged

Allow checking DNS with api.gihub.com.#4547
TingluoHuang merged 2 commits into
mainfrom
users/tihuang/dnscheck

Conversation

@TingluoHuang

Copy link
Copy Markdown
Member

@TingluoHuang
TingluoHuang requested a review from a team as a code owner July 7, 2026 20:53
Copilot AI review requested due to automatic review settings July 7, 2026 20:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the runner’s job-level connectivity diagnostics by adding an optional “connectivity + DNS” check path, intended to capture DNS resolution timing/IPs in addition to HTTP reachability, and emit richer telemetry to help diagnose endpoint resolution issues.

Changes:

  • Adds a new ConnectivityAndDNSChecks payload path to schedule background checks that include DNS resolution.
  • Enhances CheckConnectivity to optionally resolve DNS, capture resolved IPs, and split timing into DNS vs HTTP request duration.
  • Adjusts emitted connectivity logs/telemetry formatting (JSON logging, new timing fields, status code prefixing).
Show a summary per file
File Description
src/Runner.Worker/JobExtension.cs Adds background connectivity+DNS checks and extends connectivity check result/telemetry with DNS/IP/timing data.

Review details

Comments suppressed due to low confidence (1)

src/Runner.Worker/JobExtension.cs:1212

  • CheckServiceConnectivityAsync still treats only "OK" and "canceled" as non-failures, but CheckConnectivity now prefixes HTTP results (e.g. http_OK, http_canceled). This will incorrectly mark successful connectivity checks as failures and may cause misleading telemetry.
                        if (!testResult.HasFailure &&
                            result.StatusCode != "OK" &&
                            result.StatusCode != "canceled")
                        {
  • Files reviewed: 1/1 changed files
  • Comments generated: 5
  • Review effort level: Low

Comment thread src/Runner.Worker/JobExtension.cs
Comment thread src/Runner.Worker/JobExtension.cs
Comment thread src/Runner.Worker/JobExtension.cs
Comment thread src/Runner.Worker/JobExtension.cs
Comment thread src/Runner.Worker/JobExtension.cs
@TingluoHuang TingluoHuang changed the title Allow checking DNS with api.gihubt.com. Allow checking DNS with api.gihub.com. Jul 9, 2026
@TingluoHuang
TingluoHuang force-pushed the users/tihuang/dnscheck branch from d49c9f2 to 910ff5f Compare July 15, 2026 13:43
@TingluoHuang
TingluoHuang force-pushed the users/tihuang/dnscheck branch from 910ff5f to 6b74a3c Compare July 15, 2026 14:24
@TingluoHuang
TingluoHuang merged commit 9d9b3c3 into main Jul 15, 2026
20 of 21 checks passed
@TingluoHuang
TingluoHuang deleted the users/tihuang/dnscheck branch July 15, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants