perf(matrix): improve inf_norm throughput#184
Conversation
- Check row-sum finiteness once per completed row on the success path. - Replay only overflowing rows to preserve the first failing matrix coordinate. - Preserve left-to-right accumulation and const evaluation across dimensions. Closes #154
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesInfinity-norm diagnostics
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
==========================================
+ Coverage 97.81% 97.83% +0.02%
==========================================
Files 8 8
Lines 4809 4859 +50
==========================================
+ Hits 4704 4754 +50
Misses 105 105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Closes #154
Summary by CodeRabbit