Repository navigation
Use more accurate integer types for Android package fields - #31
Merged
Merged
Conversation
Android long version codes are 64-bit signed integers, so it makes sense to treat them as such in the schema for better interoperability. Furthermore, target SDK values are 32-bit signed integers, to it likewise makes sense to define them as such in the schema for better interoperability. Although the Android platform technically allows negative values for at least the version code, in practice, apps with negative long version codes don't really exist, and we enforce that version codes are positive on the backend anyway.
lberrymage
added
the
buf skip breaking
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android long version codes are 64-bit signed integers, so it makes sense to treat them as such in the schema for better interoperability. Furthermore, target SDK values are 32-bit signed integers, to it likewise makes sense to define them as such in the schema for better interoperability.
Although the Android platform technically allows negative values for at least the version code, in practice, apps with negative long version codes don't really exist, and we enforce that version codes are positive on the backend anyway.