[mlir][dxsa] Add dcl_immediate_constant_buffer instruction (variant of customdata)#215
Merged
tagolog merged 1 commit intoJul 2, 2026
Conversation
dzhidzhoev
changed the title
This is one of five variants of customdata instructions. It allows to
declare an array of immediate float vals.
In FXC disassembly, it is displayed as dcl_immediate_constant_buffer
instruction, not as customdata instruction. I guess we can follow that style.
Example:
```
dxsa.dcl_immediate_constant_buffer
[
1.000000e+00, 0.000000e+00, 0.000000e+00, 0.000000e+00,
0.000000e+00, 1.000000e+00, 0.000000e+00, 0.000000e+00,
0.000000e+00, 0.000000e+00, 1.000000e+00, 0.000000e+00,
0.000000e+00, 0.000000e+00, 0.000000e+00, 1.000000e+00
]
```
tagolog
force-pushed
the
users/dzhidzhoev/mlir/dcl_immediate_constant_buffer
branch
from
666d9f7 to
bc6d5cc
Compare
tagolog
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of five variants of customdata instruction. It allows to declare an array of immediate float vals. The array size should be a multiple of 4 (but we don't check for that in disassembler).
In FXC disassembly, it is displayed as dcl_immediate_constant_buffer instruction, not as customdata instruction. I guess we can follow that style.
Example: