[dxsa][mlir] Add bufinfo, resinfo, samplepos, sampleinfo#214
Open
kuilpd wants to merge 1 commit into
Open
Conversation
Author
|
I based this patch on #182 because it needed the extended instructions support. However, it has regular unary and binary instructions that are not yet implemented in that branch, so I had to re-add the implementation so that I could run the tests. These extra function should be removed/updated to their versions in the main branch when merging with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add resource instructions
bufinfo,resinfo,samplepos,sampleinfo.This patch also changes
verifyInstructionLengthso that it fails only if parsed operands length is greater than the specified instruction length in the opcode, and it skips the unparsed tokens if the specified instruction length is longer than parsed operands. This matches the behavior ofdxbc2dxil, which doesn't check if there are unparsed tokens left, and simply moves further to parse tokens past the specified instruction length.FXCcan outputsampleposwith an extra token in the end, not sure about other instructions.