[mlir][dxsa] Add mov, dmov, movc and swapc instructions#207
Merged
Conversation
tagolog
changed the title
tagolog
changed the title
hvdijk
reviewed
Jun 29, 2026
hvdijk
reviewed
Jun 29, 2026
| ``` | ||
|
|
||
| Both destinations are updated atomically with respect to the source | ||
| values, so reading and writing the same register is well-defined. |
Contributor
There was a problem hiding this comment.
It's well-defined but with different semantics than the above pseudocode and this description suggest. This description suggests $dst0 is updated atomically, and then $dst1 is updated atomically. That's not what happens and not how Microsoft document it (they introduce a temp variable to make the meaning clear).
Example: dxsa.mov r<0>, r<1> dxsa.dmov r<0, <x, y>>, -|r<1, <z, w, x, y>>| Signed-off-by: Vladimir Shiryaev <vshiryaev@accesssoftek.com>
Example: dxsa.swapc r<0>, r<1>, r<2>, r<3>, r<4> Signed-off-by: Vladimir Shiryaev <vshiryaev@accesssoftek.com>
Example: dxsa.dmovc r<0>, r<1>, r<2>, r<3> Signed-off-by: Vladimir Shiryaev <vshiryaev@accesssoftek.com>
tagolog
force-pushed
the
vshiryaev/dxsa-mlir-mov-dmov
branch
from
5b52e8e to
3000acf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
dxsa.mov r<0>, r<1>
dxsa.dmov r<0, <x, y>>, -|r<1, <z, w, x, y>>|
dxsa.dmovc r<0>, r<1>, r<2>, r<3>
dxsa.swapc r<0>, r<1>, r<2>, r<3>, r<4>