Skip to content

[mlir][dxsa] Add nop instruction #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzhidzhoev merged 1 commit into from
Jul 1, 2026
+24 −0
Merged

[mlir][dxsa] Add nop instruction #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions mlir/include/mlir/Dialect/DXSA/IR/DXSAOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1425,4 +1425,17 @@ def DXSA_DclThreadGroup : DXSA_Op<"dcl_thread_group"> {
let hasVerifier = 1;
}

def DXSA_Nop : DXSA_NullaryOp<"nop"> {
let summary = "no operation";
let description = [{
The `dxsa.nop` operation has no effect.

Example:

```mlir
dxsa.nop
```
}];
}

#endif // DXSA_OPS
2 changes: 2 additions & 0 deletions mlir/lib/Target/DXSA/BinaryParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2628,6 +2628,8 @@ class Parser {
case D3D10_SB_OPCODE_RET:
return PLAIN_OP(Ret, 0, 0, HasPreciseAttr::No);
// Other instructions
case D3D10_SB_OPCODE_NOP:
return PLAIN_OP(Nop, 0, 0);
case D3D11_SB_OPCODE_SYNC:
return parseSync(*opcodeToken0, beginOffset, instructionLengthInTokens,
getLocation());
Expand Down
9 changes: 9 additions & 0 deletions mlir/test/Target/DXSA/nop.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// RUN: mlir-translate --import-dxsa-hex %s | FileCheck %s
// RUN: mlir-translate --import-dxsa-hex %s | mlir-opt --verify-roundtrip

// CHECK: dxsa.module {

// CHECK-NEXT: dxsa.nop
0x0100003A

// CHECK-NEXT: }