Fix Poetry lock optional dependency parsing

[Mars-60]

Fixes #5294

Tasks

• Reviewed contribution guidelines
• PR is descriptively titled 📑 and links the original issue above 🔗
• Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  Run tests locally to check for errors.
• Commits are in uniquely-named feature branch and has no merge conflicts 📁
• Updated documentation pages (if applicable)
• Updated CHANGELOG.rst (if applicable)

Description

PoetryLockHandler incorrectly reported resolved Poetry lockfile packages as optional even when the package had optional = false in poetry.lock.

The fix maps Poetry's optional field to ScanCode's is_optional field:

is_optional = package.get("optional", False)

[AyanSinhaMahapatra]

Thanks @Mars-60 see comments for updating the tests, ready to merge otherwise.

[AyanSinhaMahapatra]

Can you use an actual test file and expected results file like in the tests above?

[AyanSinhaMahapatra]

Thanks, good catch

[AyanSinhaMahapatra]

No need to parse results and assert specifically, we run whole file results test with a test and an expected file, just check the expected behaviour and results as a whole

[Copilot]

🟢 Approval recommended

The fix correctly maps Poetry’s optional field to is_optional and is backed by updated fixtures plus a targeted regression test.

Pull request overview

Fixes PoetryLockHandler so resolved dependencies reflect Poetry’s optional = true/false flag instead of incorrectly defaulting to optional.

Changes:

• Update PoetryLockHandler.parse() to map Poetry lockfile optional → ScanCode is_optional.
• Refresh Poetry fixture expected outputs and add a minimal lockfile fixture + test covering both optional and non-optional packages.
• Document the fix in CHANGELOG.rst and add contributor to AUTHORS.rst.

File summaries

File	Description
src/packagedcode/pypi.py	Fixes optional parsing by using package.get("optional", False) when creating DependentPackage entries.
tests/packagedcode/test_pypi.py	Adds a regression test validating optional vs. required packages in a Poetry lockfile.
tests/packagedcode/data/pypi/poetry/univers-poetry.lock-expected.json	Updates expected dependency is_optional values to match optional = false in the fixture lockfile.
tests/packagedcode/data/pypi/poetry/univers-package-assembly-expected.json	Updates assembled expected outputs to align with corrected is_optional behavior.
tests/packagedcode/data/pypi/poetry/optional/poetry.lock	Adds a minimal Poetry lockfile fixture containing both optional = false and optional = true packages.
tests/packagedcode/data/pypi/poetry/optional-poetry.lock-expected.json	Adds expected parsed output for the new optional/required fixture.
CHANGELOG.rst	Adds an entry for the Poetry optional dependency parsing fix (links issue #5294).
AUTHORS.rst	Adds the contributor.

Review details

• Files reviewed: 7/8 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Mars-60]

Updated the test to use an actual Poetry lockfile fixture and expected results file, as suggested. Also removed the explicit assertions and now uses check_packages_data() for the whole result.