fix: update testAppSpec.json to the right format#1207
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis change consolidates duplicate Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
There was a problem hiding this comment.
Pull request overview
Updates the local test app specification (testAppSpec.json) used by the Java test harness to match the expected “channels/presence” structure, specifically for the persisted REST presence test channel.
Changes:
- Consolidated multiple duplicate
channelsentries with the samename(persisted:restpresence_persisted) into a single channel entry. - Moved the four presence members into one
presencearray under that channel, aligning with what the tests expect (4 presence messages).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Right now ably-java has copy of common's test app spec with some modifications, but the format may change we shouldn't rely on it, and use actual format instead
for now as a quick fix we update format for presence
Summary by CodeRabbit