Conversation
404 page - Rebuild to the new design: purple-1 wordmark, divider, H2 title and a secondary "Back to App" button, centred in the content area. Drops the TopInfoPanel shell and the now-unreferenced 404.svg illustration. Settings menu - Remove the dividers so the list reads as one continuous group, and replace the Dark Mode toggle with a Theme row (System / Light / Dark) backed by MUI's useColorScheme. The toggle could not express "System", so keeping both would have let the two controls disagree. - Extract SettingsNavRow and SettingsSubmenuList so the Language and Theme drill-ins share one row and one list across the desktop menu and the mobile drawer, and collapse SettingsMenu's three booleans and three Menu blocks into one view state with a single submenu. That also stops id="settings-menu" being emitted three times. - Scale the drawer's submenu glyphs and Back label with its larger rows; Back was stuck at the desktop 14px because disableTypography kept it off the .MuiListItemText-primary hook the drawer scales by. Buttons - Fix the pill hover. MUI's base outlined :hover background outranks the fill we set on the root, so hovering any outlined or tertiary button dropped its bg-3 surface and composited the hover tint straight onto the page (#fff to #eb in light). pillStyle and pillDark now re-assert their fill on the state selectors. Light-mode only in practice, since dark's tint lands close to the resting fill. - Move the Aave V4 arrow to the end slot, since it marks an external link. Alerts - Inline links now inherit the alert's type. MuiLink defaults to the description variant, so "Learn more" rendered 14px inside the 12px text of a data-size="small" alert; 12 alerts were affected. The sibling rule for inline buttons already did this. - Restyle the badge variant: an 8% tint, per-state glyphs, and the same colour tokens the banner severities use, so the discs keep enough contrast for their white ink in dark mode. Tokens - Correct 20 stale light values in the accent ramp, which carried their dark counterparts. Verified against the Figma color/accent collection; the data collection already matched in both modes. Elsewhere - Replace the heroicons external-link glyph with ArrowUpRightIcon at all 24 call sites. - Raise the phone gutter on the shared Container from 8px to 1rem, and drop the markets ladder steps that only restated it. - Trail the rewards icon after the APY % in tables so the rate reads first.
Mjolnir Security Review
20 PRs reviewed · 1 finding |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1.34 MB (🟡 +2.32 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Fifteen Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
93.06 KB (🟢 -21 B) |
1.43 MB |
/404 |
1.16 KB (🟢 -973 B) |
1.34 MB |
/500 |
2.44 KB (🟢 -1 B) |
1.34 MB |
/bridge |
38.26 KB (🟡 +7 B) |
1.38 MB |
/dashboard |
81.72 KB (-7 B) |
1.42 MB |
/faucet |
11.35 KB (🟢 -12 B) |
1.35 MB |
/governance |
43.18 KB (-1 B) |
1.38 MB |
/governance/ipfs-preview |
97.73 KB (🟢 -17 B) |
1.44 MB |
/governance/v3/proposal |
84.49 KB (🟢 -11 B) |
1.42 MB |
/history |
28.95 KB (🟡 +339 B) |
1.37 MB |
/markets |
54.22 KB (🟢 -12 B) |
1.39 MB |
/reserve-overview |
38.97 KB (🟢 -32 B) |
1.38 MB |
/safety-module |
55.24 KB (🟢 -15 B) |
1.39 MB |
/staking |
31.45 KB (🟢 -6 B) |
1.37 MB |
/v3-migration |
48.59 KB (-1 B) |
1.39 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
This branch was successfully deployed
1 participant
404 page
Settings menu
Buttons
Alerts
Tokens
Elsewhere
General Changes
Developer Notes
Add any notes here that may be helpful for reviewers.
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files