Skip to content

[PAUSED FOR NOW] feat: restore the market switcher to the staking page header - #3105

Draft
abjt14 wants to merge 1 commit into
mainfrom
abhijeet/ui-staking-page-add-market-picker
Draft

abjt14 wants to merge 1 commit into
mainfrom
abhijeet/ui-staking-page-add-market-picker

Conversation

@abjt14

@abjt14 abjt14 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor
Before After
Screenshot 2026-09-18 at 15 11 34 Screenshot 2026-09-18 at 15 11 53

The v3 uplift replaced the staking header's market switcher with a static
"Staking" title and pinned the page to Core. Bring the switcher back, under a
"Staking" eyebrow with a 0.75rem gap, and let the page follow the selected
market again.

Removing the pin was required rather than incidental: usePinnedMarket forces
Core on mount and restores the *previous* market on unmount, so with a switcher
present, changing market on /staking and then navigating away would silently
revert the choice. Page availability now reads the current market instead, via
a new isUmbrellaAvailable predicate — Umbrella is only deployed on Core, so
every other market gets an empty state. That also covers the test-mode case the
old check handled, hence the more general empty-state copy.

MarketSwitcher gains a hideDescription flag so the staking blurb can go through
PageHeader's existing description slot. Overriding the switcher's own blurb
would have left two components rendering the same line, and would have put page
copy inside the trigger button — whose aria-label overrides its contents, so
the sentence would have been unreachable to screen readers.

Separately, widen the PageHeader title/stats gutter from 1rem to 3rem at xl
(1575px), the breakpoint where the container cap rises from 1280px to 1632px
and there is room to spend.
@abjt14 abjt14 self-assigned this Sep 18, 2026
@odin-by-borg

odin-by-borg Bot commented Sep 18, 2026

Copy link
Copy Markdown

Mjolnir Security Review

StatusQueued for review...

View in Odin

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
interface Ready Ready Preview Sep 18, 2026 6:14am UTC

Request Review

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.34 MB (🟡 +36 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 91.82 KB (🟡 +5 B) 1.43 MB
/dashboard 81.75 KB (🟡 +5 B) 1.42 MB
/markets 53.01 KB (🟡 +5 B) 1.39 MB
/safety-module 55.15 KB (🟢 -36 B) 1.39 MB
/sgho 92.25 KB (🟡 +4 B) 1.43 MB
/staking 31.49 KB (🟢 -20 B) 1.37 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@abjt14
abjt14 marked this pull request as draft September 18, 2026 06:58
@abjt14 abjt14 changed the title feat: restore the market switcher to the staking page header [PAUSED FOR NOW] feat: restore the market switcher to the staking page header Sep 18, 2026

This branch was successfully deployed

1 active deployment
Preview 15fe7552 Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant