Repository navigation
call-log 0.1.1: tokenize parsed headers, tolerate Hono's executionCtx getter, accept httpsig's fetch - #31
Merged
Conversation
… getter, accept httpsig's fetch Found while wiring the seven fleet workers (access #9, senzing #12, test-resource #2, whoami #3, notes #4, web-agent-demo #7, registry #9): - partOf left a resource token inside a parsed AAuth-Requirement (every auth-token challenge) as the JWT string. It is tokenized now, like a body, so no record holds a presentable token. - The middleware read `c.executionCtx?.waitUntil` as a property; Hono's getter throws where there is no execution context (Node, app.request), which 500ed every request on senzing's Node entrypoint and in tests. - HttpsigFetchLike did not accept @hellocoop/httpsig's fetch, which is overloaded on dryRun / returnSent; loggedHttpsigFetch had never been used. The options are `any` now, and the result is unwrapped by shape. - README: the callee record waits on the client reading the response (workerd's clone is a tee), and a constant fake Signature in a harness gives every call the same call_id. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014n2B6Qwjkwkdft4ms5NgMF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three defects in
@aauth/call-log0.1.0, found while wiring the seven fleet workers today (access #9, senzing #12, test-resource #2, whoami #3, notes #4, web-agent-demo #7, registry #9). Each worker carries a guard for the first two; once 0.1.1 is on npm, the guards can go.partOfdid not tokenizeparams. A resource token insideAAuth-Requirement(every auth-token challenge, every step-up) was logged as the presentable JWT. Now tokenized like a body. Test: the parsed challenge carries{type, payload}and the JWT string appears nowhere in the record.c.executionCtx?.waitUntilthrows on Hono outside Workers. Hono'sexecutionCtxis a getter that throws when there is none (the Node entrypoint,app.requestin tests), so the middleware 500ed every request there. Read through try/catch now. Test: a context whose getter throws is logged, not failed.HttpsigFetchLikerejected@hellocoop/httpsig'sfetch, which is overloaded ondryRun/returnSent.loggedHttpsigFetchhad never been used before access @mntu/hardware-keys v0.11.2 #9 (cast there). Options areanynow; the result is unwrapped by shape. Test: an overloaded function typed like httpsig's is accepted and itssentheaders name the call.README: two notes for hosts (the callee record waits on the client reading the response, since workerd's
clone()is a tee; a constant fakeSignaturein a harness gives every call onecall_id).Version 0.1.1. 22 tests pass;
tscclean. Publishing needs the trusted publisher on npmjs (still yours), or a manual publish like 0.1.0.🤖 Generated with Claude Code
https://claude.ai/code/session_014n2B6Qwjkwkdft4ms5NgMF