fix: use ReplicatedImageRegistry noProxy=true for SDK airgap registry#58
Merged
Conversation
For airgap: returns local embedded registry address For online: noProxy=true returns proxy.replicated.com unchanged Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single change: adds
replicated.image.registryoverride usingReplicatedImageRegistry "proxy.replicated.com" true.noProxy=truereturns the registry unchanged (proxy.replicated.com) → no behavior changePrevious attempts used
HasLocalRegistryandLocalRegistryHostwhich are not available in the helmchart.yaml template context. This uses onlyReplicatedImageRegistrywhich is confirmed available.Test plan
RunningRunning🤖 Generated with Claude Code