fix: add SDK and gameshelf to builder section for airgap bundling#57
Merged
Conversation
Add SDK to builder section so it gets bundled for airgap. Remove the values-section registry override — EC3 may auto-mirror proxy.replicated.com for airgap; if not, we'll address it after confirming what functions are available in this template context. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
builder.image(ghcr.io/aa-replicated/gameshelf) so the Vendor Portal bundles the main app image correctlybuilder.replicated.image(proxy.replicated.com/library/replicated-sdk-image) so the SDK image is included in the airgap bundlevaluesregistry override —HasLocalRegistryandLocalRegistryHostare not available in the helmchart.yaml template context; EC3 may auto-mirrorproxy.replicated.com→ local registry once the image is bundledTest plan
RunningRunning(SDK is the open question)🤖 Generated with Claude Code