fix: use LocalRegistryHost for SDK registry override in airgap#56
Merged
Conversation
HasLocalRegistry is not available in helmchart.yaml template context. LocalRegistryHost returns empty string for online installs, so | default "proxy.replicated.com" handles both cases cleanly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HasLocalRegistry(not available in helmchart.yaml template context) withLocalRegistryHost | default "proxy.replicated.com"LocalRegistryHostreturns empty string → falls back toproxy.replicated.com(SDK works natively)LocalRegistryHostreturns the embedded registry address → SDK pulls from local registryTest plan
RunningRunning🤖 Generated with Claude Code