fix: EC3 beta.1 + correct ReplicatedImageRegistry pattern for airgap#52
Merged
Conversation
…attern - Bump embedded cluster version to 3.0.0-beta.1+k8s-1.34 - Pass original registry hosts to ReplicatedImageRegistry (ghcr.io, index.docker.io) per docs — function returns full proxy prefix for online and local registry address for airgap - Add image.repository override (aa-replicated/gameshelf) so airgap pulls from <local-registry>/aa-replicated/gameshelf, not proxy path - Remove bitnami repository overrides — Bitnami chart defaults are already the correct original paths - Restore HelmValue pattern for SDK registry Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3.0.0-beta.1+k8s-1.34helmchart.yamlto follow the docs-correct pattern forReplicatedImageRegistry:"ghcr.io","index.docker.io") — the function returns the full proxy prefix for online (proxy.replicated.com/proxy/gameshelf/<registry>) and the local registry address for airgapimage.repository: aa-replicated/gameshelfoverride so airgap uses<local-registry>/aa-replicated/gameshelf:tag(not the proxy-path-prefixed repo)HelmValuepattern for SDK registryExpected image URLs:
proxy.replicated.com/proxy/gameshelf/ghcr.io/aa-replicated/gameshelf:<tag><local>/aa-replicated/gameshelf:<tag>proxy.replicated.com/proxy/gameshelf/index.docker.io/bitnami/postgresql:<tag><local>/bitnami/postgresql:<tag>proxy.replicated.com/proxy/gameshelf/index.docker.io/bitnami/redis:<tag><local>/bitnami/redis:<tag>Test plan
Running, image refs show full proxy prefixRunning, image refs show local registry address🤖 Generated with Claude Code