Repository navigation
fix(server): prevent failed cancel from overwriting terminal task state - #1405
Open
Iwaniukooo11 wants to merge 1 commit into
Open
Iwaniukooo11 wants to merge 1 commit into
Iwaniukooo11 wants to merge 1 commit into
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/agent_execution/active_task.py | 95.84% | 96.10% | 🟢 +0.26% |
| src/a2a/server/cluster/database_event_stream.py | 97.27% | 93.64% | 🔴 -3.64% |
| Total | 93.44% | 93.41% | 🔴 -0.02% |
Generated by coverage-comment.yml
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1397
Issue
Cancel event could overwrite a
taskthat was already in terminated stateChange
On producer site: Ensured that
taskis not in terminal state when enqueueingOn consumer site: If
taskis in terminal state, drop the current processing event (and.taskdone()on queue)Test
Added tests that ensure that cancellation events do not overwrite terminal state
Also, re-runned
reproprovided in issue desc to validate that after the changes, flow works as expected