Repository navigation
feat(cluster): Introduce ServerCallContext to DatabaseTaskEventStream - #1399
Merged
Iwaniukooo11 merged 3 commits intoOct 29, 2026
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/agent_execution/active_task.py | 95.79% | 95.84% | 🟢 +0.05% |
| src/a2a/server/cluster/database_event_stream.py | 92.86% | 93.64% | 🟢 +0.78% |
| src/a2a/server/request_handlers/default_request_handler_v2.py | 88.68% | 88.98% | 🟢 +0.30% |
| Total | 93.37% | 93.40% | 🟢 +0.03% |
Generated by coverage-comment.yml
Iwaniukooo11
force-pushed
the
mateusziwaniuk/1374-add-server-context-to-event_stream
branch
from
October 29, 2026 11:16
17d8fc3 to
244541d
Compare
Iwaniukooo11
marked this pull request as ready for review
October 29, 2026 11:21
mykytanetipa
requested changes
Oct 29, 2026
mykytanetipa
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling ServerCallContext in DatabaseTaskEventStream methods
closes #1374
Change
This PR adds
contexttoDatabaseTaskEventStreammethods:subscribe,publish,destroyTo keep it backward-compatible, it doesen't change
TaskEventStreamabstract class.Instead,
DefaultRequestHandlerand activetaskEventConsumercheck if methods of currentTaskEventStreaminstance supportcontextarg; otherwise, they warn.Also,
_seq_at_or_before_versionmethod addsownercondition to followTaskStoreownership behaviourIn long-term, the
TaskEventStreammethods should includecontextarg (breaking change, #1398)Tests
Added 3 tests - Ensuring that warnings are logged when using
TaskEventStreaminstance, that owner is accepted and that owner can't see other owner events