Release 1.1.23: the left-edge swipe works under gesture navigation, and databases get a menu - #73
Merged
Merged
Conversation
…atabases get a menu A Play Store review reported that the sidebars "don't appear as intended" because of gesture control, and that databases could not be managed like folders. Android gesture navigation takes every swipe that starts at a screen edge as Back. The WebView received touchstart then touchcancel, Browse never opened, the swipe navigated back instead, and from Home it left the app. EdgeSwipePlugin excludes a 32dp x 200dp band of the left edge, centred mid-screen, from the Back gesture (200dp is the most Android honours per edge), as androidx DrawerLayout does for its drawer. The shell claims the band on the phone layout while the drawer is closed and releases it while the drawer is open, so Back still closes the drawer. Back keeps working above and below the band and along the whole right edge. Android-only; iOS has no edge Back gesture. The Swipe gestures setting said the edge swipe "always opens Browse", which was false here. It now says where the swipe works and points at the flick options, which already open Browse or the outline from anywhere on a note. Long-pressing a database in Browse went straight to the delete confirmation. It now opens the same sheet folders use, with Rename (requestRenameBrowseDatabase, public since core 2.51.0) and Delete. Moving a database needs a core action that ships with a later core. Verified on the Android 15 emulator with gesture navigation: Android holds the exclusion region while the drawer is closed and drops it while open; a left-edge swipe mid-screen opens Browse, the same swipe near the top is still Back, and Back closes the open drawer; renaming a database through the new sheet renamed its folder on disk with its contents intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release 1.1.23 (versionCode 26). Two fixes prompted by a Play Store review; the vendored core stays at app core 2.51.0.
touchstartthentouchcancel, Browse never opened, the swipe navigated back, and from Home it left the app. The new Android-onlyEdgeSwipePluginexcludes a 32dp x 200dp band of the left edge, centred mid-screen, from the Back gesture (200dp is the most Android honours per edge), as androidxDrawerLayoutdoes for its drawer. The shell claims the band on the phone layout while the drawer is closed and releases it while the drawer is open, so Back still closes it. Back keeps working above and below the band and along the whole right edge.requestRenameBrowseDatabase) and Delete.MobileDrawer.tsxis shared with the iPhone shell, so the database menu should be ported there; the plugin has no iOS counterpart because iOS has no edge Back gesture.Not in this release: the command-palette focus fix (#65) and moving folders or databases. Both are committed to the desktop
v2.52.0branch and arrive when that core is published and vendored.Validation
navigation_mode2), build from67765e3: upgrade from 1.1.22 over existing data; Android holdsmSystemGestureExclusion=SkRegion((0,974,84,1499))while the drawer is closed and an empty region while it is open; a left-edge swipe mid-screen opens Browse, Back from that edge closes the open drawer, and the same swipe near the top of the screen is still Back; long-pressing a database opens "Database actions" (Rename, Delete), the backdrop closes it, and the next tap opens a note; renaming a database renamed its.basefolder on disk with its contents intact; an edit autosaved to the device filesystem and a cold relaunch restored it; no crashes or console errors.4a31a71df8cdc7757c792267eb85b8fe0fb7b796506de587e949bd64adbaafd8; all 469 web assets matchdist/byte for byte.After merge
Tag
v1.1.23on the merge commit and attach the Play-signed universal APK after confirming it contains nocom.pairipcode and noCHECK_LICENSEpermission.