feat(core,internal/ethapi): add MaxUsedGas field to eth_simulateV1 response #31735 #32789 #34820

[gzliudan]

Proposed changes

Ref:

• core, eth/gasestimator: introduce MaximumGasUsed for estimation ethereum/go-ethereum#31735
• internal/ethapi: add MaxUsedGas field to eth_simulateV1 response ethereum/go-ethereum#32789
• ethclient: add maxUsedGas to simulate call results ethereum/go-ethereum#34820

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d40d6d88-2e77-4ea8-a88a-c20f22184d73

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Adds a new maxUsedGas value to eth_simulateV1 call results by plumbing an additional gas metric from core execution into the RPC response. This improves simulation output by exposing both refunded (gasUsed) and pre-refund (“gross”) gas usage.

Changes:

• Extend core.ExecutionResult with MaxUsedGas and compute it in the state transition before applying refunds (and adjusted for Prague floor gas).
• Extend internal/ethapi’s eth_simulateV1 per-call response object to include maxUsedGas.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
internal/ethapi/simulate.go	Adds maxUsedGas to the JSON response for each simulated call.
core/state_transition.go	Computes and returns ExecutionResult.MaxUsedGas alongside UsedGas.