fix: document OffPayrollWorker value in EmploymentStatus enum - #845
Open
mikkelgaub-planday wants to merge 1 commit into
Open
fix: document OffPayrollWorker value in EmploymentStatus enum#845mikkelgaub-planday wants to merge 1 commit into
mikkelgaub-planday wants to merge 1 commit into
Conversation
The API already returns OffPayrollWorker as an EmploymentStatus value; it was omitted from the enum by oversight. Adding it fixes deserialization of existing GET responses. No functional change to request handling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Payroll UK API already returns
OffPayrollWorkeras anEmploymentStatusvalue, but it was omitted from the enum in the spec by oversight. This adds the missing value so generated SDKs can deserialize existing GET responses.Why this is not a breaking change
isOffPayrollWorkerboolean flag already exists on the employee DTO and is how off-payroll workers are created; that behaviour is unchanged.OffPayrollWorkeras anEmploymentStatuswhen creating a payee or adding a contract, so no new request capability is introduced.Replaces the approach in #802 (which was flagged as a breaking change). This is a documentation/deserialization fix, not a functional change.