Skip to content

Script Loader: Don't check is_feed() before the main query is run in block asset functions. - #14551

Open
shrivastavanolo wants to merge 2 commits into
WordPress:trunkfrom
shrivastavanolo:fix/63693-block-assets-on-demand-early
Open

shrivastavanolo wants to merge 2 commits into
WordPress:trunkfrom
shrivastavanolo:fix/63693-block-assets-on-demand-early

Conversation

@shrivastavanolo

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/63693

Summary

wp_should_load_separate_core_block_assets() and wp_should_load_block_assets_on_demand() run early (init, wp_default_styles), before the main query exists, so their is_feed() check can't return a meaningful result.

This adds a private helper, _wp_is_non_frontend_request_for_block_assets(), used by both functions. It checks is_admin() and wp_is_rest_endpoint() as before, and only calls is_feed() once the wp action has fired.

REST requests still can't be detected at init, since REST_REQUEST isn't defined until parse_request. Fixing that would mean moving block registration later, which could break code that expects it on init.

Use of AI Tools

AI assistance: Yes
Tool(s): Clade code
Model(s): Sonnet 5.5
Used for: Initial code skeleton and test suggestions; final implementation and tests were reviewed and edited by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shreya0shrivastava.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant