Repository navigation
Script Loader: Don't check is_feed() before the main query is run in block asset functions. - #14551
shrivastavanolo wants to merge 2 commits into
Conversation
…block asset functions.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Trac ticket: https://core.trac.wordpress.org/ticket/63693
Summary
wp_should_load_separate_core_block_assets()andwp_should_load_block_assets_on_demand()run early (init,wp_default_styles), before the main query exists, so theiris_feed()check can't return a meaningful result.This adds a private helper,
_wp_is_non_frontend_request_for_block_assets(), used by both functions. It checksis_admin()andwp_is_rest_endpoint()as before, and only callsis_feed()once thewpaction has fired.REST requests still can't be detected at
init, sinceREST_REQUESTisn't defined untilparse_request. Fixing that would mean moving block registration later, which could break code that expects it oninit.Use of AI Tools
AI assistance: Yes
Tool(s): Clade code
Model(s): Sonnet 5.5
Used for: Initial code skeleton and test suggestions; final implementation and tests were reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.