Skip to content

Abilities API: Encode empty object results as JSON objects #14547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jorgefilipecosta wants to merge 5 commits into
base: trunk
Choose a base branch
from
+1,092 −78
Open

Abilities API: Encode empty object results as JSON objects #14547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a5e128
REST API: Allow routes to disable `_fields`, `_embed` and response li…
jorgefilipecosta Oct 21, 2026
5b2ee49
REST API: Let routes turn off `_fields`, `_embed` and response links.
jorgefilipecosta Oct 22, 2026
c93e5de
REST API: Serve response data that is not an array as returned.
jorgefilipecosta Oct 22, 2026
257351a
Abilities API: Encode empty object results as JSON objects.
jorgefilipecosta Oct 21, 2026
cd02d31
Abilities API: Register the run endpoint with the `response_processin…
jorgefilipecosta Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/wp-includes/rest-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,6 +950,8 @@ function _rest_array_intersect_key_recursive( $array1, $array2 ) {
* Filters the REST API response to include only an allow-listed set of response object fields.
*
* @since 4.8.0
* @since 7.2.0 The response is left unchanged when the route turns off the `fields` response
* processing or when the response data is not an array.
*
* @param WP_REST_Response $response Current response being served.
* @param WP_REST_Server $server ResponseHandler instance (usually WP_REST_Server).
Expand All @@ -961,8 +963,21 @@ function rest_filter_response_fields( $response, $server, $request ) {
return $response;
}

if ( $server instanceof WP_REST_Server ) {
$processing = $server->get_response_processing( $request, $response );

if ( ! $processing['fields'] ) {
return $response;
}
}

$data = $response->get_data();

// Only arrays have fields to filter.
if ( ! is_array( $data ) ) {
return $response;
}

$fields = wp_parse_list( $request['_fields'] );

if ( 0 === count( $fields ) ) {
Expand Down Expand Up @@ -993,7 +1008,7 @@ function rest_filter_response_fields( $response, $server, $request ) {
if ( wp_is_numeric_array( $data ) ) {
$new_data = array();
foreach ( $data as $item ) {
$new_data[] = _rest_array_intersect_key_recursive( $item, $fields_as_keyed );
$new_data[] = is_array( $item ) ? _rest_array_intersect_key_recursive( $item, $fields_as_keyed ) : $item;
}
} else {
$new_data = _rest_array_intersect_key_recursive( $data, $fields_as_keyed );
Expand Down Expand Up @@ -3048,7 +3063,7 @@ function rest_preload_api_request( $memo, $path ) {
/** This filter is documented in wp-includes/rest-api/class-wp-rest-server.php */
$response = apply_filters( 'rest_post_dispatch', rest_ensure_response( $response ), $server, $request );
$embed = $request->has_param( '_embed' ) ? rest_parse_embed_param( $request['_embed'] ) : false;
$data = (array) $server->response_to_data( $response, $embed );
$data = $server->response_to_data( $response, $embed, $request );

if ( 'OPTIONS' === $method ) {
$memo[ $method ][ $path ] = array(
Expand Down
Loading
Loading