Repository navigation
Tests: Add unit test coverage for _get_plugin_data_markup_translate() - #14522
Open
huzaifaalmesbah wants to merge 1 commit into
Open
huzaifaalmesbah wants to merge 1 commit into
huzaifaalmesbah wants to merge 1 commit into
Conversation
huzaifaalmesbah
marked this pull request as ready for review
October 20, 2026 05:35
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mukeshpanchal27
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for
_get_plugin_data_markup_translate(), which translates, sanitizes and marks up the plugin header data shown on the Plugins screen. The only existing coverage istest_get_plugin_data(), which checks the markup of Hello Dolly; the translation path, the sanitization of untrusted header values and the empty-field cases had no tests.The tests call the function directly with header data, record
translate()calls through thegettextfilter, and replace the text domain registry with a mock to check where the text domain is loaded from. They cover:wp_kses()on the name (no links), author, description and version, andesc_url()on both URIs, using markup, disallowed tags, attributes and entity characters;TitleandAuthorNameholding the sanitized values without markup;'0';defaulttext domain (also inside a plugin directory), and other plugins without a text domain not being translated;Domain Path, and not again when it is already loaded.Removing or changing each branch of the function makes at least one test fail.
This is a test-only change; no production code is modified.
Testing Instructions
npm run test:php -- --filter Tests_Admin_Includes_Plugin_GetPluginDataMarkupTranslatenpm run test:php -- --filter Tests_Admin_Includes_Plugin_GetPluginDataMarkupTranslate -c tests/phpunit/multisite.xmlnpm run test:php -- --filter Tests_Admin_Includes_Plugin_GetPluginDataMarkupTranslate --order-by=randomnpm run test:php -- --group pluginsnode ./tools/local-env/scripts/docker.js run --rm php ./vendor/bin/phpcs tests/phpunit/tests/admin/includes/plugin/getPluginDataMarkupTranslate.phpTrac ticket: https://core.trac.wordpress.org/ticket/65819
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Brainstorming edge-case scenarios and drafting test boilerplate; test architecture, assertions, and local PHPUnit verification were written and validated by me.