Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
peterwilsoncc
left a comment
peterwilsoncc
left a comment
Contributor
There was a problem hiding this comment.
Couple of notes inline, I think only the update-core changes can be actioned in wordpress-develop so the other items can be done upstream and included in the next sync.
| return ''; | ||
| } | ||
|
|
||
| // Background skips serialization, so apply it to the link like color. |
Contributor
There was a problem hiding this comment.
None blocker but it's unclear what "link like" means -- is it a typo?
Can be done in the next sync if needs to be committed upstream.
| __FUNCTION__, | ||
| sprintf( | ||
| /* translators: 1: Template part ID, 2: Error message. */ | ||
| __( 'Error when loading the template part %1$s from the database: %2$s' ), |
Contributor
There was a problem hiding this comment.
Suggested change
| __( 'Error when loading the template part %1$s from the database: %2$s' ), | |
| __( 'Error loading the template part %1$s from the database: %2$s' ), |
Member
Author
There was a problem hiding this comment.
Here's a fix for those strings - #85176.
Contributor
|
Commit log generated with the command (with the first hash been the old, the second the new) git log --reverse --format="- %s" 954fe7f9e04631c41aec4552acd627a7203a2aad..7b95ee96b54de2e35886971ccf7eb449c324c830 | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d'Commit log. |
This updates the pinned commit hash of the Gutenberg repository from `954fe7f9e04631c41aec4552acd627a7203a2aad` (version `24.1.0`) to `7b95ee96b54de2e35886971ccf7eb449c324c830` (version `24.2.0`). A full list of changes included in this commit can be found on GitHub: WordPress/gutenberg@954fe7f...7b95ee9. Gutenberg 24.2 no longer builds `wp-includes/js/dist/sync.js` or its minified counterpart, so both are added to `$_old_files` to be removed on upgrade. They were listed under 7.0.2 and restored in 7.1. See #66340.
peterwilsoncc
force-pushed
the
66340-sync-gutenberg-24.2
branch
from
October 20, 2026 03:23
2cbf9e5 to
7e5549a
Compare
Contributor
This was referenced Oct 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs changes from Gutenberg 24.2.0 by updating the pinned Gutenberg hash from
954fe7f(24.1.0) to7b95ee9(24.2.0), and regenerating the synced files withnpm run build:dev.The large number of changed files is mainly due to:
vector-effect="non-scaling-stroke"attribute (block-default.svgis also redrawn).dimensions(minWidth/minHeight) andshadowsupport added to many core blocks'block.json, also reflected inblocks-json.php.keywords.@wordpress/syncis no longer built, and a newcore/coverview script module.One manually managed file is also updated:
wp-includes/js/dist/sync.jsandsync.min.jsare added to$_old_files, since Gutenberg 24.2 no longer builds them.Full list of changes: WordPress/gutenberg@954fe7f...7b95ee9
Trac ticket: https://core.trac.wordpress.org/ticket/66340
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Grunt work; reviewed by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.