Repository navigation
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
fushar
force-pushed
the
icons-skip-kses-bundled
branch
from
October 19, 2026 11:08
3908ac2 to
e85a551
Compare
fushar
marked this pull request as ready for review
October 19, 2026 11:26
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
t-hamano
reviewed
Oct 23, 2026
The core icons ship with WordPress and are trusted, and sanitizing them with wp_kses() is the main cost of rendering them.
fushar
force-pushed
the
icons-skip-kses-bundled
branch
from
October 23, 2026 04:15
e85a551 to
fa2f8de
Compare
Author
|
@t-hamano Thanks for the review and welcome back! All make sense, I've applied them and re-test this PR. |
wporg-sync
pushed a commit
that referenced
this pull request
Oct 27, 2026
Icons that ship with WordPress in the core icon library are no longer sanitized when they are loaded, because they are reviewed and versioned like the rest of core. This cuts the server time it takes to render the admin bar and admin menu icons on every admin screen. Icons registered by plugins and themes are still sanitized. Developed in: #14492 Props fushar, softglaze, wildworks. Fixes #66338. git-svn-id: https://develop.svn.wordpress.org/trunk@64800 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Oct 27, 2026
Icons that ship with WordPress in the core icon library are no longer sanitized when they are loaded, because they are reviewed and versioned like the rest of core. This cuts the server time it takes to render the admin bar and admin menu icons on every admin screen. Icons registered by plugins and themes are still sanitized. Developed in: WordPress/wordpress-develop#14492 Props fushar, softglaze, wildworks. Fixes #66338. Built from https://develop.svn.wordpress.org/trunk@64800 git-svn-id: http://core.svn.wordpress.org/trunk@63950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/66338.
Backport of WordPress/gutenberg#85083.
Skips the
wp_kses()sanitization of the core icons bundled with WordPress, inwp-includes/images/icon-library/.#12270 renders the admin bar and admin menu icons with
wp_get_icon(), so every wp-admin page now loads about 20 icons through the registry. Measurements on that PR show about +3.5 ms of server time per wp-admin page, and most of the icon cost iswp_kses(). The core icons ship with WordPress and are as trusted as the rest ofwp-includes, so sanitizing does not really protect anything.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: code generation, with my supervision.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.