Tests: Add unit tests for `wp_start_scraping_edited_file_errors()` by shail-mehta · Pull Request #14483 · WordPress/wordpress-develop

shail-mehta · 2026-10-19T08:55:24Z

What

Trac ticket: #65819

Adds unit tests for wp_start_scraping_edited_file_errors() in tests/phpunit/tests/load/wpStartScrapingEditedFileErrors.php.

Covers missing/empty scrape params, a missing scrape transient, and a matching nonce that enables sandbox scraping.

Test-only change.

Why

This helper has had no dedicated PHPUnit coverage. Fits the #65819 missing-coverage track, and no open PR covers it.

How

Return early without scrape request params, empty params, or a missing transient
Define WP_SANDBOX_SCRAPING when the scrape key and nonce match

Testing instructions

npm run test:php -- --filter Tests_Load_WpStartScrapingEditedFileErrors

Use of AI Tools

Cursor

Copilot

🟡 Changes recommended

The early-return tests need process isolation to prevent failures caused by constants defined by earlier tests.

1 open issue

Isolate early-return tests from persistent WP_SANDBOX_SCRAPING state · New

What changed in this PR

Adds dedicated PHPUnit coverage for wp_start_scraping_edited_file_errors() as part of ticket #65819, without changing production code.

Changes:

Tests early returns for missing or empty request parameters and a missing transient.
Tests sandbox activation when the nonce matches.

File	Description
tests/phpunit/tests/load/wpStartScrapingEditedFileErrors.php	Adds four tests with request and transient cleanup.

_{Review effort: Balanced}

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

🟢 Approval recommended

The isolated tests cover the stated scenarios, with no blocking issues identified.

No open issues 🎉

1 resolved since last review

Isolate early-return tests from persistent WP_SANDBOX_SCRAPING state

_{Review effort: Balanced}

github-actions · 2026-10-19T09:21:40Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

mukeshpanchal27

The assertions match wp_start_scraping_edited_file_errors(). Two points about process isolation inline.

mukeshpanchal27 · 2026-10-19T11:05:48Z

+ *
+ * @group load
+ *
+ * @runTestsInSeparateProcesses


Only the last test defines WP_SANDBOX_SCRAPING, and it already has @runInSeparateProcess. The first three tests assert that the constant is not defined, so they can run in the normal process. Could this class-level @runTestsInSeparateProcesses and @preserveGlobalState disabled be removed?

mukeshpanchal27 · 2026-10-19T11:05:48Z

+		$_REQUEST['wp_scrape_key']   = $key;
+		$_REQUEST['wp_scrape_nonce'] = $nonce;
+
+		wp_start_scraping_edited_file_errors();


When the nonce matches, this call registers wp_finalize_scraping_edited_file_errors() as a shutdown function. That function prints the scrape markers when the child process exits, after PHPUnit has written the test result. It works today, but it adds output to the child process result. Could the test remove that output, or note in a comment why it is safe?

Done in latest commits.

…ors-tests

Copilot

🔵 Needs a closer look

The early-return tests need isolation to prevent false failures when earlier tests have already defined the sandbox constant.

No open issues 🎉

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

No blocking issues were identified in this focused test-only change; tests were not executed.

No open issues 🎉

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

The focused test-only changes cover the stated scenarios with no identified blocking issues.

No open issues 🎉

_{Review effort: Balanced}

lancewillett

The early-return cases preserve constant state, with process isolation limited to the successful registration case.

The unit-tests audit is complete. This class passed independently, and the ten-PR batch passed randomized single-site and multisite runs (61 tests, 95 assertions each). PHPCS passed. I also reviewed the fresh Copilot feedback.

_{AI review · gpt-6}

lancewillett · 2026-10-19T19:12:02Z

PR #14483 landed in https://core.trac.wordpress.org/changeset/64562

Cover early returns and successful registration in `wp_start_scraping_edited_file_errors()`. Isolate the case that defines a constant and registers a shutdown callback. Developed in: #14483 Props shailu25, mukesh27. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64562 602fd350-edb4-49c9-b593-d223f7449a82

Cover early returns and successful registration in `wp_start_scraping_edited_file_errors()`. Isolate the case that defines a constant and registers a shutdown callback. Developed in: WordPress/wordpress-develop#14483 Props shailu25, mukesh27. See #65819. Built from https://develop.svn.wordpress.org/trunk@64562 git-svn-id: http://core.svn.wordpress.org/trunk@63712 1a063a9b-81f0-0310-95a4-ce76da25c4cd

Tests: Add unit tests for wp_start_scraping_edited_file_errors()

b2b9a04

shail-mehta self-assigned this Oct 19, 2026

shail-mehta requested a balanced review from Copilot October 19, 2026 08:55

Copilot started reviewing on behalf of shail-mehta October 19, 2026 08:56

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

Comment thread tests/phpunit/tests/load/wpStartScrapingEditedFileErrors.php

Add annotations for test process and global state

d87762e

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

shail-mehta requested a balanced review from Copilot October 19, 2026 08:59

Copilot started reviewing on behalf of shail-mehta October 19, 2026 08:59

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

shail-mehta marked this pull request as ready for review October 19, 2026 09:21

shail-mehta requested a review from lancewillett October 19, 2026 09:21

mukeshpanchal27 reviewed Oct 19, 2026

View reviewed changes

shail-mehta added 4 commits October 19, 2026 16:55

Apply Feedback Changes

b18fe18

Merge branch 'trunk' into 65819-add-wp-start-scraping-edited-file-err…

2c804ef

…ors-tests

Clean up transient handling in test case

491092e

Add test for defining WP_SANDBOX_SCRAPING

4dd9f19

shail-mehta requested a balanced review from Copilot October 19, 2026 12:23

Copilot started reviewing on behalf of shail-mehta October 19, 2026 12:23

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

shail-mehta added 2 commits October 19, 2026 18:03

Update wpStartScrapingEditedFileErrors.php

223fcbc

Refactor tests for wpStartScrapingEditedFileErrors

568a29e

shail-mehta requested a balanced review from Copilot October 19, 2026 13:03

Copilot started reviewing on behalf of shail-mehta October 19, 2026 13:04

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

lancewillett requested a balanced review from Copilot October 19, 2026 19:01

Copilot started reviewing on behalf of lancewillett October 19, 2026 19:02

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

lancewillett approved these changes Oct 19, 2026

View reviewed changes

lancewillett closed this Oct 19, 2026

Navigation Menu

Repository navigation

Tests: Add unit tests for `wp_start_scraping_edited_file_errors()` - #14483

Tests: Add unit tests for `wp_start_scraping_edited_file_errors()`#14483
shail-mehta wants to merge 8 commits into
WordPress:trunkfrom
shail-mehta:65819-add-wp-start-scraping-edited-file-errors-tests

shail-mehta commented Oct 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Oct 19, 2026 •

edited

Loading

Uh oh!

mukeshpanchal27 left a comment

Uh oh!

mukeshpanchal27 Oct 19, 2026

Uh oh!

mukeshpanchal27 Oct 19, 2026

Uh oh!

shail-mehta Oct 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

lancewillett left a comment

Uh oh!

lancewillett commented Oct 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

shail-mehta commented Oct 19, 2026

What

Why

How

Testing instructions

Use of AI Tools

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

github-actions Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mukeshpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

mukeshpanchal27 Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

mukeshpanchal27 Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

shail-mehta Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

lancewillett left a comment

Choose a reason for hiding this comment

Uh oh!

lancewillett commented Oct 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Oct 19, 2026 •

edited

Loading