Editor: Ignore unsupported duotone attribute types

[yotatameguchi-boop]

When style.color.duotone is a boolean or a number, WP_Duotone::render_duotone_support() reaches add_class() with an undefined $filter_id. Return the original block HTML for attribute types other than string or array, and make the remaining branches exhaustive using the existing early return for blocks without local or global duotone settings.

Add regression coverage for false, true, an integer and a float, and regenerate the variable.undefined PHPStan baseline to remove the resolved occurrence.

Trac ticket: https://core.trac.wordpress.org/ticket/65817

Validation on PHP 8.3:

• The four regression cases fail on unmodified trunk with Undefined variable $filter_id.
• vendor/bin/phpunit --group block-supports: 449 tests, 605 assertions pass.
• vendor/bin/phpstan analyse --memory-limit=2G: no errors.
• WordPress PHPCS for both changed PHP files and git diff --check: pass.

AI assistance: OpenAI Codex generated the code, regression tests and PR description.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @yotatameguchi-boop.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props westonruter, ramonopoly, isabel_brison.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[westonruter]

I see “preset” mentioned and I immediately think of @ramonjd's PR #14262 which seems related (as it's also about type safety). Requesting his review as well.

[westonruter]

Actually, I see the code was introduced by @tellthemachines in d966798. So maybe she can review as well.

[westonruter]

Good. I can see that $filter_id is now assigned in all branches of the conditional.

Before this change, PhpStorm also flags an error:

[yotatameguchi-boop]

Thanks for checking this in PhpStorm as well! With the early type guard, unsupported attribute values return unchanged and every remaining branch assigns $filter_id.

[ramonjd]

Hello! I think we'd need to sync Gutenberg's copy as well lib/class-wp-duotone-gutenberg.php

[yotatameguchi-boop]

Thanks for pointing out the Gutenberg copy! I have opened WordPress/gutenberg#84801 to sync the early type guard and exhaustive branches, with coverage for the four unsupported attribute values. The existing isset( $filter_id ) guard in Gutenberg is preserved.

Validation: all 27 duotone tests (27 assertions), Gutenberg PHPCS for both changed PHP files, and the production build pass. PHP syntax checks also pass on PHP 7.4 and 8.3. The Gutenberg PR includes a backport-changelog entry linking it to this Core PR.

[ramonjd]

Thanks for the ping, @westonruter. I checked for overlaps. #14262 cleans theme.json preset definitions in WP_Theme_JSON::sanitize(), and not at render time, so no dependencies.

I was just checking against #14262, which drops invalid types by the time they get to the loop that's changed in this PR.

[tellthemachines]

Actually, I see the code was introduced by @tellthemachines in d966798. So maybe she can review as well.

I just committed that PR years ago, didn't actually write it 😅
This looks like a sensible change though!

[tellthemachines]

I was just checking against #14262, which drops invalid types by the time they get to the loop that's changed in this PR.

Still worth making this change IMO, if for no other reason than it makes the code a little more readable.

[yotatameguchi-boop]

Thanks @tellthemachines for reviewing and clarifying the history! Agreed: making the supported types explicit and the remaining branches exhaustive improves readability even where the upstream sanitization already filters invalid values. The corresponding Gutenberg change is in WordPress/gutenberg#84801, which you have also tested and approved. Thanks for checking both implementations!

[yotatameguchi-boop]

The corresponding Gutenberg change has now been merged: WordPress/gutenberg#84801 (96a5cfaaabd629d5908a1d17b0c3bf7683343f36). This completes the Gutenberg sync requested above. Thanks everyone for the reviews and testing!

[tellthemachines]

@yotatameguchi-boop would you like to create a wordpress.org account so we can give you props on the commit?

[yotatameguchi-boop]

Thanks @tellthemachines! My WordPress.org username is yotatameguchi, and my profile is https://profiles.wordpress.org/yotatameguchi/. Please use that username for the props. Thank you for making sure my contribution is credited!

[tellthemachines]

LGTM!

[tellthemachines]

Closing as committed in https://core.trac.wordpress.org/changeset/64493. Thanks everyone!