Skip to content

Administration: Fix misaligned title placeholder and file tree arrows - #14218

Closed
Adi-ty wants to merge 2 commits into
WordPress:trunkfrom
Adi-ty:fix/66294-admin-line-height-misalignment
Closed

Adi-ty wants to merge 2 commits into
WordPress:trunkfrom
Adi-ty:fix/66294-admin-line-height-misalignment

Conversation

@Adi-ty

@Adi-ty Adi-ty commented Oct 12, 2026 •

Copy link
Copy Markdown

63965 changed the body line-height in common.css from 1.4em (fixed 18.2px) to unitless 1.4, so descendants now compute their own font-size × 1.4. Two elements that relied on the old fixed value are misaligned:

  1. Classic Editor title placeholder (#title-prompt-text): text shifted down inside the title field. Fixed with line-height: 1, matching #title.
  2. Theme/Plugin File Editor folder arrows ([role="treeitem"] span[aria-hidden]): arrow no longer aligned with the folder name. Fixed with line-height: 1.

Trac ticket: https://core.trac.wordpress.org/ticket/66294

Screenshot

Screenshot 2026-10-13 at 9 13 36 AM Screenshot 2026-10-13 at 9 10 18 AM

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Sonnet 5.5
Used for: Locating the affected selectors


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Adi-ty
Adi-ty marked this pull request as ready for review October 13, 2026 03:34
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props iamadisingh, afercia.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano
t-hamano requested a review from afercia October 13, 2026 08:00

@afercia afercia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @Adi-ty. If you see more glitches related to line-height do feel free to create new tickets. The change to the body line-height may trigger some more glitches but it was necessary to adapt to the WordPress CSS Coding Standards for #12934

@afercia afercia added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Oct 13, 2026
@github-actions github-actions Bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Oct 13, 2026
wporg-sync pushed a commit that referenced this pull request Oct 13, 2026
…ne-height.

Follow-up to [63965], which changed the body line-height in `common.css` from 1.4em to 1.4 to adapt to the WordPress CSS Coding Standards.

- Adjusts the line height for the Classic Editor post title 'placeholder'.
- Adjusts the line height for arrow icons in the Plugin and Theme file editors.

Developed in #14218

Props iamadisingh, wildworks.
See #65898.
Fixes #66294.


git-svn-id: https://develop.svn.wordpress.org/trunk@64328 602fd350-edb4-49c9-b593-d223f7449a82
@github-actions

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 64328
GitHub commit: 1d0881a

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Oct 13, 2026
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Oct 13, 2026
…ne-height.

Follow-up to [63965], which changed the body line-height in `common.css` from 1.4em to 1.4 to adapt to the WordPress CSS Coding Standards.

- Adjusts the line height for the Classic Editor post title 'placeholder'.
- Adjusts the line height for arrow icons in the Plugin and Theme file editors.

Developed in WordPress/wordpress-develop#14218

Props iamadisingh, wildworks.
See #65898.
Fixes #66294.

Built from https://develop.svn.wordpress.org/trunk@64328


git-svn-id: http://core.svn.wordpress.org/trunk@63478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants