Repository navigation
Build/Test Tools: Test localized packages in the install and upgrade tests - #13867
Draft
adimoldovan wants to merge 1 commit into
Draft
adimoldovan wants to merge 1 commit into
adimoldovan wants to merge 1 commit into
Conversation
…tests. The install and upgrade tests use only the en_US package. Localized packages can be missing after a release, and no test reports it. Add a locale job next to the existing PHP and database matrices, in both workflows. A locale is tested when it has a localized package for an earlier release on the same branch. - Install: download, verify checksums, install and smoke check the localized package. - Upgrade: update a localized site from the same branch, with the en_US package and a language pack (as automatic updates do), and with the localized package (as a manual update does). The smoke check now reads its text markers from WordPress, so it also works on a localized site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: TBD
Add a locale job to
install-testing.ymland toupgrade-testing.yml. The existing PHP × database matrices stay the same.$wp_local_package, verify the checksums, install and run the smoke check.auto: update with the en_US package, thenwp language core update. This is what automatic updates do.manual: update with the localized package. This is whatwp core update --localeand "Update now" do.A locale is tested when it has a localized package for the branch's X.Y release or the previous minor release. Locales below the translation thresholds have no package, so they are not tested.
The timing of the localized packages and language packs build is not clear. If these workflows run before the builds finish, the locale jobs fail for almost every locale. This happens when:
latestto a release that is only a few hours old,Other things to know
WordPress/wordpress-develop/.github/actions/smoke-check@trunk, like the existing jobs. The old trunk script looks for the English text "Hello world!" and "No Update Required", so the smoke step fails on this PR's own CI until thesmoke-check.shchange is on trunk. Thesmoke-check.shchange could go in first as a separate commit.latestandnightlyare tested as the latest stable release, because there are no localized nightly builds. Thus the weekly install run checks the current release. An X.Y target or a pre-release has no earlier release on its branch, so no locales are tested for it and the run shows a notice.Testing Instructions
The jobs run only in
WordPress/wordpress-develop. To test on a fork, temporarily change thegithub.repositoryconditions and point the smoke-check action to the fork branch. Then:wp-versionset to7.1.2, and again with6.9.9.new-versionset to7.1.2.autoupgrade jobs pass.I ran the job scripts locally against MySQL 8.4, using the WP-CLI steps from the workflows. it_IT, fr_FR, de_DE and ja pass. ar fails at the download, as expected. I have not yet dispatched the workflows on a fork.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Implementation, local testing and review of the workflow changes and this description. I reviewed the result.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.